Update controller.rb

[illtellyoulater]

fixed to return a valid path for a file in the root of a jar

[byteit101]

What about "" (empty string)? Also we might want "/" to work also, do you have any opinions @enebo ?

[illtellyoulater]

I tried that before. File.join("","file.txt") => "/file.txt" so no good.
Concerning "/", a || condition could be added to the check for "."
Is it possible to update the pull request or do I have to delete and make a new one?

[amiracam]

I'm sorry what I missed something what is this accomplishing ? Is this about not being able to load the fxml file ?

[illtellyoulater]

yes, when running from a jar, for a .fxml file living in the jar root, defined by the second argument of fxml_root in mair script with ("fxml_root filesystem/path", ".")

[edubkendo]

@jjgh any commits you push to the branch your PR was on will automatically be added to the PR.

[amiracam]

ok, I see, in my case I used :

fxml_root File.dirname(FILE), 'src/lib'

the way I packed things up my code is under /src at root of jar, the only thing right on root is JarMain.class which would be part of warbler's packaging

src/bin
is where the launcher class resides wherein I add src/lib to load path
I then require my app

I suppose it provides for more flexibility to be able to grab fxml file from root, but I generally would not want to pack that way and its certainly not the defaults warbler likes

[byteit101]

ah, no, I was saying should we check for "" and "/" and if so don't append either?

[illtellyoulater]

if you are asking to me, yea that is what I tried to say when you first asked :)
@amiracam maybe it sounds more reasonable to place .fxml files somewhere else, but I would just like avoid someone else a big headache if by chance they choose to use the root folder.

[amiracam]

Sure , I'm also suggesting it due to warbler
On Dec 4, 2013 7:53 AM, "jjgh" notifications@github.com wrote:

if you are asking to me, yea that is what I tried to say when you first
asked :)
@amiracam https://github.com/amiracam maybe it sounds more reasonable
to place .fxml files somewhere else, but I would just like avoid someone
else a big headache if by chance they choose to use the root folder.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/77#issuecomment-29802095
.

[enebo]

HEH, "/". The pedantic side of me realizes that is someone wants their fxml in / of their machine it will stop working if they are trying to load from a jar file :) I would say the check should be a reasonably named method or there should be a simple comment explaining the rationale. I guess I don't care one way or the other on "/".

[byteit101]

Actually, when I think about it, "" should do this, but "." and "/" should (eventually) do file paths.

[enebo]

Yeah I guess that was the gist of my pedantry...

[byteit101]

@jjgh mind making "" do jars and "." and "/" do files? (I can fix it myself if you don't mind, though I might not be able to do it given the immense scale of your patch 😉 )

[illtellyoulater]

Thanks for merging it, it was my first commit into a big open source project! Great :)