Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

de.saumya.mojo group ID is hardcoded most places #37

Closed
headius opened this issue Aug 3, 2023 · 0 comments
Closed

de.saumya.mojo group ID is hardcoded most places #37

headius opened this issue Aug 3, 2023 · 0 comments
Milestone
1.2.0

Comments

@headius
Copy link
Member

headius commented Aug 3, 2023

I am currently working on updating the JRuby/Maven stack, and ran into an issue with the jruby_plugin DSL because it hardcodes the group ID for JRuby/Maven plugins as "de.saumya.mojo".

As part of work on jruby/mavengem#9 and jruby/jruby-maven-plugins#126 I have moved these projects under the "org.jruby.maven" group ID. When attempting to build JRuby after that move (working against snapshots of jruby-maven-plugins and mavengem) the build for JRuby's test dir failed to resolve de.saumya.mojo:gem-maven-plugin before the build could even run.

The issue appears to be twofold:

  • The jruby_plugin DSL hardcodes "de.saumya.mojo" as the group ID.
  • It also inherits the version of those plugins from the build, but I'm not clear how this is happening.

The maven-tools will need to be updated to support both group IDs, most likely, and we'll need to investigate if and how we can isolate the execution of the pom.rb from the use of jruby-maven-plugins during the build.

For now I will be replacing the one use of jruby_plugin with a normal plugin call.
headius added a commit to headius/jruby that referenced this issue Aug 3, 2023
@headius
Update jruby-maven-plugins to new group and version
27507ba 
This update is necessary to get JRuby 9.4.3.0 running throughout
the JRuby/Maven stack, which is necessary to move to the new
mavengems.

See jruby/jruby-maven-plugins#126

See jruby/mavengem#9

There is also a change to replace the use of `jruby_plugin` in
test/pom.rb with a normal `plugin` DSL call, due to the former
hardcoding an old package for the jruby-maven-plugins.

See jruby/maven-tools#37
headius added a commit to headius/jruby that referenced this issue Aug 3, 2023
@headius
Update jruby-maven-plugins to new group and version
3f7f7e8 
This update is necessary to get JRuby 9.4.3.0 running throughout
the JRuby/Maven stack, which is necessary to move to the new
mavengems.

See jruby/jruby-maven-plugins#126

See jruby/mavengem#9

There are also changes to replace the use of `jruby_plugin` in
several poms with a normal `plugin` DSL call, due to the former
hardcoding an old package for the jruby-maven-plugins.

See jruby/maven-tools#37
@headius headius mentioned this issue Aug 3, 2023
Merged
headius added a commit to headius/polyglot-maven that referenced this issue Aug 3, 2023
@headius
Update JRuby and all JRuby/Maven plugins
5dadf0a 
This is part of work to update the entire JRuby/Maven stack, in
order to update the version of JRuby used and to address API
deprecations at rubygems.org.

This PR updates JRuby to latest (9.4.3.0) and moves all plugins
to their new org.jruby.maven group ID with latest versions.

Part of the fix for jruby/maven-tools#37.

We will need to coordinate getting this released along with the
maven plugins in the very near term. Because of the rubygems.org
API being shut down next week (the 8th), we are under the gun.

See jruby/mavengem#9, jruby/jruby-maven-plugins#126,
jruby/maven-tools#38 and jruby/jruby#7872.
headius added a commit to headius/polyglot-maven that referenced this issue Aug 4, 2023
@headius
Update JRuby and all JRuby/Maven plugins
11d1881 
This is part of work to update the entire JRuby/Maven stack, in
order to update the version of JRuby used and to address API
deprecations at rubygems.org.

This PR updates JRuby to latest (9.4.3.0) and moves all plugins
to their new org.jruby.maven group ID with latest versions.

Part of the fix for jruby/maven-tools#37.

We will need to coordinate getting this released along with the
maven plugins in the very near term. Because of the rubygems.org
API being shut down next week (the 8th), we are under the gun.

See jruby/mavengem#9, jruby/jruby-maven-plugins#126,
jruby/maven-tools#38 and jruby/jruby#7872.
headius added a commit to headius/polyglot-maven that referenced this issue Aug 4, 2023
@headius
Update JRuby and all JRuby/Maven plugins
b10aaad 
This is part of work to update the entire JRuby/Maven stack, in
order to update the version of JRuby used and to address API
deprecations at rubygems.org.

This PR updates JRuby to latest (9.4.3.0) and moves all plugins
to their new org.jruby.maven group ID with latest versions.

The maven-tools gem is updated to 1.2.

Part of the fix for jruby/maven-tools#37.

We will need to coordinate getting this released along with the
maven plugins in the very near term. Because of the rubygems.org
API being shut down next week (the 8th), we are under the gun.

See jruby/mavengem#9, jruby/jruby-maven-plugins#126,
jruby/maven-tools#38 and jruby/jruby#7872.
headius added a commit to headius/jruby that referenced this issue Aug 4, 2023
@headius
Update jruby-maven-plugins to new group and version
337ac4a 
This update is necessary to get JRuby 9.4.3.0 running throughout
the JRuby/Maven stack, which is necessary to move to the new
mavengems.

See jruby/jruby-maven-plugins#126

See jruby/mavengem#9

There are also changes to replace the use of `jruby_plugin` in
several poms with a normal `plugin` DSL call, due to the former
hardcoding an old package for the jruby-maven-plugins.

See jruby/maven-tools#37
@headius headius closed this as completed in bea7d19 Aug 4, 2023
headius added a commit to headius/jruby that referenced this issue Aug 9, 2023
@headius
Update jruby-maven-plugins to new group and version
b7d600a 
This update is necessary to get JRuby 9.4.3.0 running throughout
the JRuby/Maven stack, which is necessary to move to the new
mavengems.

See jruby/jruby-maven-plugins#126

See jruby/mavengem#9

There are also changes to replace the use of `jruby_plugin` in
several poms with a normal `plugin` DSL call, due to the former
hardcoding an old package for the jruby-maven-plugins.

See jruby/maven-tools#37
@headius headius added this to the 1.2.0 milestone Aug 9, 2023
cstamas added a commit to takari/polyglot-maven that referenced this issue Aug 25, 2023
@cstamas
Merge pull request #263 from headius/update_jruby_and_plugins
7c61a48 
This is part of work to update the entire JRuby/Maven stack, in order to update the version of JRuby used and to address API deprecations at rubygems.org.

This PR updates JRuby to latest (9.4.3.0) and moves all plugins to their new org.jruby.maven group ID with latest versions.

Part of the fix for jruby/maven-tools#37. (incorrectly tagged as #37 here before)

We will need to coordinate getting this released along with the maven plugins in the very near term. Because of the rubygems.org API being shut down next week (the 8th), we are under the gun.

See jruby/mavengem#9, jruby/jruby-maven-plugins#126, jruby/maven-tools#38 and jruby/jruby#7872.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
1 participant
@headius