-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not use sllice_size=0 for compilation - hiding compile errors #388
Comments
there's a default slice size 2500 ... setting the default lower would cause more |
@kares my default was zero, not sure if this here is a expectation issue. No matter what your application internal default is ( 2500 ) the configuration default is zero and should be addressed. |
double checked, that would mean a failure (tested with JRuby 9.1.5.0) and also no compiling :
|
Not sure what happened here but with default settings I was getting aforementioned
|
The default slice_size is 0, which leads to an issue tht e.g. if a gem connot be compiled, lets say erubis due to the syntax issue here: EugenMayer/erubis@d34acfd
then you end up having just a message
compilation of .rb file failed
and thats it, also with--trace
no further information givenUsing slice_size 10 here https://github.com/jruby/warbler/blob/master/lib/warbler/jar.rb#L58 , i end up having proper errors like
or
for the issue with https://github.com/rails/rails/blob/master/activejob/lib/rails/generators/job/templates/job.rb
I suggest either having a setting in warble.rb to set it to zero, but by default, make it non zero so people do not run into such dead-ends an probably stop there jruby evaluation because "things magically wont compile"
Thanks!
The text was updated successfully, but these errors were encountered: