Skip to content
This repository has been archived by the owner on Apr 8, 2021. It is now read-only.

Add support for auto plugins in sbt 0.13.5 #51

Closed
jasonchaffee opened this issue Jul 6, 2014 · 8 comments
Closed

Add support for auto plugins in sbt 0.13.5 #51

jasonchaffee opened this issue Jul 6, 2014 · 8 comments
Labels

Comments

@jasonchaffee
Copy link

Add support for auto plugins in sbt 0.13.5

@jrudolph
Copy link
Member

jrudolph commented Jul 7, 2014

Can you explain more which kind of behavior you are missing that would be enabled by supporting an auto-plugin style?

@jasonchaffee
Copy link
Author

I have this plugin being configured in a corporate level plugin and thus the configuration is inherited by every project. I would be really nice to have this in the corporate plugin but be able to disable in this as needed in a select few projects that we still want to use the corporate plugin but the dependency-graph plugin has some issues or conflicts. I am not sure what the issues are as they are not my projects.

It would make using the plugin much easier as well as all I would have to do something like this:

def myCompanytProject(projectName: String): Project = (
Project(projectName, ".")
settings(myCompanySettings: _*)
enablePlugins(PlayJava)
enablePlugins(SbtWeb)
enablePlugins(DependnecyGraph)
)

Then, a project that wants to turn it off can simply do this:

myCompanyProject(“foo”)
disablePlugins(DenpendencyGraph)

This is one of the use cases it was defined for and something that we are heavily using already with all of the Play,SbtWeb and Typesafe plugins that have updated already.

On Jul 7, 2014, at 1:06 AM, Johannes Rudolph notifications@github.com wrote:

Can you explain more which kind of behavior you are missing that would be enabled by supporting an auto-plugin style?


Reply to this email directly or view it on GitHub.

@jrudolph
Copy link
Member

jrudolph commented Jul 7, 2014

Thanks for the explanation. I agree that this would be useful.

@metasim
Copy link
Member

metasim commented Mar 5, 2015

I'd also appreciate having this as an autoPlugin. That way one can have in in the sbt global plugins and have the settings automatically merged without changing shared build files. If it's an effort thing, would you be open to a PR containing the conversion?

@muuki88
Copy link

muuki88 commented Nov 16, 2015

I could make a pull request, but I'm not familiar with the sbt-crosscompile stuff and how to handle this. How important is the backwards compatibility with sbt 12.x and pre 13.5?

@jrudolph
Copy link
Member

Thanks @muuki88 for the offer. I'm just wrapping up a new version which also has autoplugin support which I hope to have ready soon. So, don't bother with a PR this time.

@muuki88
Copy link

muuki88 commented Nov 16, 2015

Okay :) Looking forward to it

@jrudolph
Copy link
Member

Fixed in adc55e3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants