Skip to content
This repository has been archived by the owner on Apr 8, 2021. It is now read-only.

Include cummulative sizes for each column at the end of the list modu… #100

Conversation

alexblickenstaff
Copy link

@alexblickenstaff alexblickenstaff commented May 24, 2016

…le stats.

This information is printed to the console immediately following the list of all ModuleStats entries.

@jrudolph
Copy link
Member

Thanks for this proposal, @alexblickenstaff. Could you explain a bit why you need this? It seems to me that summing up entries which already contain cumulative or transitive sizes doesn't make much sense and the resulting numbers wouldn't correspond to anything useful.

@alexblickenstaff
Copy link
Author

Good question, I see what you're saying.

There are two purposes. The first (and most important) is to give a sense of the percentage of the total space each dependency is taking up to help prioritize cleanup. An alternative approach would be explicitly stating the percentage of each as another column.

The other purpose (less important) is to display the jar's total size. This is just a relevant piece of information given the task at hand.

I felt that adding a single row at the bottom was a less intrusive way of getting the aforementioned information compared to adding another column for each row.

@jrudolph
Copy link
Member

Closing this for now. I agree it could be useful to have some more numbers in this command. However, this won't cut it as things are summed up which make no sense. Most of the numbers in the columns are overlapping with other rows, so blind summing will lead to counting things several times.

@jrudolph jrudolph closed this Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants