Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformers fail without categorical features #53

Closed
dholzmueller opened this issue Oct 6, 2021 · 3 comments
Closed

Transformers fail without categorical features #53

dholzmueller opened this issue Oct 6, 2021 · 3 comments

Comments

@dholzmueller
Copy link

The models SAINT, FTTransformer and TabFastFormer contain the code

        if self.n_cont and not self.n_cat and not self.embed_continuous:
            raise ValueError(
                "If only continuous features are used 'embed_continuous' must be set to 'True'"
            )

The variable self.embed_continuous is not set anywhere, probably it has been used in an older version of the code and was then replaced by True later. For data sets without categorical features, this code raises an error. Removing this code should resolve the issue.

@jrzaurin
Copy link
Owner

jrzaurin commented Oct 7, 2021

hi @dholzmueller

thanks, I will review this asap

jrzaurin added a commit that referenced this issue Oct 7, 2021
jrzaurin added a commit that referenced this issue Oct 7, 2021
Fixed issue #53 related to the use of some transformer models without categorical columns
@jrzaurin
Copy link
Owner

jrzaurin commented Oct 7, 2021

The issue is now fixed and merged into master.

I will publish to pypi asap, in the meantime please install via github

@jrzaurin
Copy link
Owner

jrzaurin commented Oct 7, 2021

It is now available on pypi (v.1.0.10)

Thanks for the issue. Closing it now

@jrzaurin jrzaurin closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants