Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump grunt-contrib-qunit from 3.1.0 to 5.0.1 #711

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 23, 2021

Bumps grunt-contrib-qunit from 3.1.0 to 5.0.1.

Release notes

Sourced from grunt-contrib-qunit's releases.

v5.0.1

  • Run grunt 7410588
  • Merge pull request #179 from Krinkle/fix-timeout 188a29a
  • Restore page timeout handling and fail.timeout event 5ba6324
  • readme: Fix broken markdown link (#172) f558142
  • Merge pull request #177 from gruntjs/dependabot/npm_and_yarn/lodash-4.17.21 f0e0fb0
  • Merge pull request #176 from gruntjs/dependabot/npm_and_yarn/grunt-1.3.0 a949ae0
  • Bump lodash from 4.17.19 to 4.17.21 c5fd7e1
  • Bump grunt from 1.1.0 to 1.3.0 4bc4d76
  • Merge pull request #175 from Krinkle/release d46ed00
  • Release 5.0.0 de2da5e
  • Update grunt-contrib-internal (Travis CI to GitHub Actions) 024f541
  • Merge pull request #173 from Krinkle/pup-5 14969d0
  • Update to Puppeteer 5 ca15b69
  • Merge pull request #169 from gruntjs/dependabot/npm_and_yarn/lodash-4.17.19 c2101b2
  • Bump lodash from 4.17.15 to 4.17.19 c73cfdb
  • Merge pull request #168 from gruntjs/v4-rel a971cbc
  • Merge pull request #167 from gruntjs/update-deps-4 7caf136

gruntjs/grunt-contrib-qunit@v4.0.0...v5.0.1

v4.0.0

No release notes provided.

Changelog

Sourced from grunt-contrib-qunit's changelog.

v5.0.0: date: 2021-04-18 changes: - Puppeteer version to ^5.0.0. - Dependency updates. v4.0.0: date: 2020-06-17 changes: - Puppeteer version to v4.0.0. - Dependency updates and typo fixes. - Minimum node version is now version 10.

Commits
  • 188a29a Merge pull request #179 from Krinkle/fix-timeout
  • 5ba6324 Restore page timeout handling and fail.timeout event
  • f558142 readme: Fix broken markdown link (#172)
  • f0e0fb0 Merge pull request #177 from gruntjs/dependabot/npm_and_yarn/lodash-4.17.21
  • a949ae0 Merge pull request #176 from gruntjs/dependabot/npm_and_yarn/grunt-1.3.0
  • c5fd7e1 Bump lodash from 4.17.19 to 4.17.21
  • 4bc4d76 Bump grunt from 1.1.0 to 1.3.0
  • d46ed00 Merge pull request #175 from Krinkle/release
  • de2da5e Release 5.0.0
  • 024f541 Update grunt-contrib-internal (Travis CI to GitHub Actions)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 23, 2021
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/grunt-contrib-qunit-5.0.1 branch from 1e6c2b9 to 64dbb24 Compare July 23, 2021 05:43
Bumps [grunt-contrib-qunit](https://github.com/gruntjs/grunt-contrib-qunit) from 3.1.0 to 5.0.1.
- [Release notes](https://github.com/gruntjs/grunt-contrib-qunit/releases)
- [Changelog](https://github.com/gruntjs/grunt-contrib-qunit/blob/main/CHANGELOG)
- [Commits](gruntjs/grunt-contrib-qunit@v3.1.0...v5.0.1)

---
updated-dependencies:
- dependency-name: grunt-contrib-qunit
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/grunt-contrib-qunit-5.0.1 branch from 64dbb24 to 5d9a4e4 Compare July 23, 2021 05:53
@carhartl
Copy link
Member

Having problems with installing puppeteer on M1...

@carhartl
Copy link
Member

Following advice from puppeteer/puppeteer#6622 (comment), that is installing chromium via homebrew and setting up the environment:

PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
PUPPETEER_EXECUTABLE_PATH=/opt/homebrew/bin/chromium

I'm able to run npm install -d, but when trying to run tests getting:

Running "qunit:all" (qunit) task
>> There was an error with headless chrome
Fatal error: Failed to launch the browser process! spawn /usr/bin/chromium-browser ENOENT

This? puppeteer/puppeteer#5662

@carhartl
Copy link
Member

carhartl commented Sep 12, 2021

The reason is: https://github.com/puppeteer/puppeteer/blob/491614c7f8cfa50b902d0275064e611c2a48c3b2/src/node/Launcher.ts#L124

PUPPETEER_EXECUTABLE_PATH isn‘t taken into account it seems.

Should be possible to symlink this in place for the time being 🤔

@carhartl
Copy link
Member

Should be possible to symlink this in place for the time being

No, due to system integrity protection on macOS.

@carhartl
Copy link
Member

Setting puppeteer's executablePath according to https://github.com/gruntjs/grunt-contrib-qunit#custom-timeouts-and-puppeteer-options also does not have an effect..

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 13, 2021

Superseded by #731.

@dependabot dependabot bot closed this Sep 13, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/grunt-contrib-qunit-5.0.1 branch September 13, 2021 21:21
@carhartl
Copy link
Member

See: puppeteer/puppeteer#6957

@carhartl
Copy link
Member

I have to leave it at that: we're stuck with Puppeteer 5.5.0: https://github.com/gruntjs/grunt-contrib-qunit/blob/53729ce04f44e2340ab64add95903db4755a3592/package.json#L21 where Chrome's executable path is being hardcoded for M1 envs: https://github.com/puppeteer/puppeteer/blob/18143b3573e3e9e637ae43c3f757bed8b752634f/src/node/Launcher.ts#L107-L108

The problem might solve itself as soon as there are Chrome executables to download automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

None yet

1 participant