Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic-release npm publish #27

Closed
wants to merge 10 commits into from
Closed

semantic-release npm publish #27

wants to merge 10 commits into from

Conversation

crobinson42
Copy link
Member

@crobinson42 crobinson42 commented Sep 21, 2016

Note: This project uses semantic-release to auto publish npm packages on successful builds.
The commit messages must follow AngularJS Commit Msg Conventions: https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit#heading=h.uyo6cb12dt6w

  • - My commit messages follow AngularJS Commit Msg Conventions
  • - If applicable, appropriate JSDoc comments were updated in source code
  • - If applicable, appropriate changes to js-data.io docs have been suggested ("Suggest Edits" button)
  • - Unit test coverage did not decrease & appropriate tests changes made

crobinson42 and others added 9 commits September 14, 2016 16:44
* docs(.github/): add comments on semantic-release to PR template .md

* chore(build-steps): add semantic-release package and circle.yml configs for auto npm publish
* docs(.github/): add comments on semantic-release to PR template .md

* chore(build-steps): add semantic-release package and circle.yml configs for auto npm publish

* test(coverage): add tests to increase coverage
* docs(.github/): add comments on semantic-release to PR template .md

* chore(build-steps): add semantic-release package and circle.yml configs for auto npm publish

* test(coverage): add tests to increase coverage

* test(): add missed return stmt

* fix(test): demo fix testing semantic-release
* docs(.github/): add comments on semantic-release to PR template .md

* chore(build-steps): add semantic-release package and circle.yml configs for auto npm publish

* test(coverage): add tests to increase coverage

* test(): add missed return stmt

* fix(test): demo fix testing semantic-release

* chore(build): add release branch to the semantic-release config
@codecov-io
Copy link

codecov-io commented Sep 21, 2016

Current coverage is 80.35% (diff: 100%)

Merging #27 into release will decrease coverage by 1.91%

@@            release        #27   diff @@
==========================================
  Files             2          2          
  Lines           282        336    +54   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            232        270    +38   
- Misses           50         66    +16   
  Partials          0          0          

Powered by Codecov. Last update bd420c5...1213d5c

@crobinson42
Copy link
Member Author

Heads-up >> repo-tools write-version will break with semantic-release implementation due to semantic-release removing the version out of the package.json file.

ie: tests fail:

> js-data-mongodb@ bundle /Users/willlyrob/projects/js-data-mongodb
> rollup -c rollup.config.js -f cjs -o dist/js-data-mongodb.js -m dist/js-data-mongodb.js.map src/index.js && repo-tools write-version dist/js-data-mongodb.js

Cannot read property 'split' of undefined

* fix(test): demo fix testing semantic-release

* test(update.test.js): comment out unused code

* docs(): small docs changes

* test(): add custom mongodb query test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants