Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering by nested fields #133

Closed
jmdobry opened this issue May 5, 2015 · 6 comments
Closed

Allow filtering by nested fields #133

jmdobry opened this issue May 5, 2015 · 6 comments
Assignees
Milestone

Comments

@jmdobry
Copy link
Member

jmdobry commented May 5, 2015

No description provided.

@jmdobry jmdobry self-assigned this May 5, 2015
@jmdobry jmdobry added this to the 2.0.0 milestone May 10, 2015
jmdobry added a commit that referenced this issue May 10, 2015
@jmdobry jmdobry added done and removed in progress labels May 10, 2015
@jmdobry jmdobry closed this as completed May 10, 2015
@sinsunsan
Copy link

this closed for 2.0 only or also for 1.? @jmdobry

@jmdobry
Copy link
Member Author

jmdobry commented May 11, 2015

It's in 2.0. Perhaps I could backport it to 1.x

@sinsunsan
Copy link

If it is not too complicate, would be nice to have it on 1.X, as it's the version we currently use.

By the way, it is easy the move to 2.X version ? Should we wait for it to stabilize ? Do you have a doc, to how to migrate ?

@jmdobry
Copy link
Member Author

jmdobry commented May 13, 2015

2.x is under the beta tag in npm. The CHANGELOG.md file in the 2.0 branch documents breaking changes.

@chillyprig
Copy link

Let's say I have

customer: {
    addresses: [
      {
        detail: "a"
      },
      {
        detail: "b"
      },
      {
        detail: "c"
      }
    ]
}

Is there any example to filter address inside of the customer?

@jmdobry
Copy link
Member Author

jmdobry commented Jun 10, 2015

Unless you're filtering on a property of the addresses array, such as its length, or unless you have actual references to those details objects and you're trying to filter by them, then any other type of filtering on a nested array containing objects is too advanced for js-data's default filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants