DS#find() returns items cached with DS#inject()

[mightyguava]

DS#find() currently only returns the cached item early only if a
previous request was made to fetch the item. If the item was added using
DS#inject(), DS#find() will make a request anyways. This makes DS#find()
return the item directly instead.

[jmdobry]

I hesitate to call the current behavior a bug, so I am not keen on making this change as it would be a breaking change. As recently discussed in #117, we actually want to make this configurable. By making it configurable, we can avoid a breaking change, but allow you to achieve the behavior that this PR implements. In js-data 2.0 we can make the breaking change have the default behavior be that find will immediately resolve if an item was injected manually into the store.

So, can you make one more commit to your branch that adds a configuration option called findStrictCache that defaults to true? You can add it right below findBelongsTo here.

Then, the boolean expression in DS#find should be if ((!options.findStrictCache || id in resource.completedQueries) && _this.get(resourceName, id)) {

So, until 2.0 when I remove the option and change behavior, in your own app you can set findStrictCache to false.

Thanks!

[mightyguava]

Oops, I saw the bug but the title totally didn't register as relevant. Will make it configurable.

[mightyguava]

Updated.

Btw, my use case is mostly for testing, so making this an option really does make a lot of sense. It's quite convenient to use DS#inject() to set up a mock data set and set findStrictCache to false to prevent lookups.

[jmdobry]

Awesome!