Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): splits tests into smaller ones #406

Merged
merged 1 commit into from Sep 20, 2016
Merged

refactor(test): splits tests into smaller ones #406

merged 1 commit into from Sep 20, 2016

Conversation

stalniy
Copy link
Contributor

@stalniy stalniy commented Sep 18, 2016

First of all, as you probably know js-data is the most awesome js ORM library. This is actually the only one reason why I'm trying to improve codebase.

But frankly speaking the current state of unit tests are horrible, so I'd like to show how complex unit tests can be split into smaller one which follows single responsibility principle. This makes them to be more readable, clear and SOLID (in all senses), you don't need to scroll few pages down in order to see where the test ends =)

As I mention in #405 I plan to add few more tests for create and createMany methods of Mapper class but for now it's hard to choose proper location. Probably I will do some other initial refactoring in tests just to make the resulting changes to be more clear (i.e., without refactoring noise)

@jmdobry
Copy link
Member

jmdobry commented Sep 20, 2016

Any help with tests is greatly appreciated!

@jmdobry jmdobry merged commit 4ea4fda into js-data:master Sep 20, 2016
@jmdobry
Copy link
Member

jmdobry commented Sep 20, 2016

First of all, as you probably know js-data is the most awesome js ORM library.

Awesome! I hope with continuing community contributions like yours it can continue to improve :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants