refactor(test): splits tests into smaller ones #406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, as you probably know js-data is the most awesome js ORM library. This is actually the only one reason why I'm trying to improve codebase.
But frankly speaking the current state of unit tests are horrible, so I'd like to show how complex unit tests can be split into smaller one which follows single responsibility principle. This makes them to be more readable, clear and SOLID (in all senses), you don't need to scroll few pages down in order to see where the test ends =)
As I mention in #405 I plan to add few more tests for
create
andcreateMany
methods ofMapper
class but for now it's hard to choose proper location. Probably I will do some other initial refactoring in tests just to make the resulting changes to be more clear (i.e., without refactoring noise)