Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable pendingQueries optimizations when usePendingFind or usePendingFindAll are false #492

Merged
merged 1 commit into from Feb 14, 2018

Conversation

eldridge
Copy link

@eldridge eldridge commented Feb 2, 2018

Fixes #364

  • - npm test succeeds
  • - Code coverage does not decrease (if any source code was changed)
  • - If applicable, appropriate JSDoc comments were updated in source code (if applicable)
  • - If applicable, approprate changes to js-data.io docs have been suggested ("Suggest Edits" button)

@crobinson42
Copy link
Member

@eldridge thx - unit tests?

@eldridge
Copy link
Author

eldridge commented Feb 2, 2018

I'm taking a look at the test suite now. I'm hoping I can access resource.pendingQueries from inside a test. If so, I think that'll work.

…ending queries in the corresponding pendingQueries cache (ref js-data#364)
@eldridge
Copy link
Author

eldridge commented Feb 2, 2018

Unit tests added. I did uncover a bug in my original PR that I fixed. Thanks for the quick response prompting me to do that. I tried to run the tests before submitting the PR, but I ran into a few early issues that I neglected to muscle through.

I think the issue there was bower looking for js-data 3. I fixed it by pinning the js-data and js-data-http versions to ^2.0.0 in bower.json. I've included that in this PR as well.

All of the tests pass now. I also confirmed that my newly added tests fail in 2.10.0 vanilla.

@eldridge
Copy link
Author

eldridge commented Feb 2, 2018

One other thing. I did not update the various files in dist/*. There were a lot of changes in there and I wasn't comfortable pushing them. Let me know if I should go ahead and add those, though.

@jmdobry
Copy link
Member

jmdobry commented Feb 14, 2018

No, I'll generate the dist files for the release.

@jmdobry jmdobry merged commit 7f83bf8 into js-data:v2 Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants