-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements js2r-kill
#25
Conversation
Expect edge-cases
When the buffer has parse errors, fallback to `kill-line`
14ddac4
to
00ea041
Compare
There are still some rough edge cases like the following:
If I kill, I would expect to have:
The question is if it's worth the effort (we have the same issue with if statements, for statements, etc). My guess is yes :) |
I think it's in a decent shape now. At the end I went with the following strategies:
|
40241f7
to
5d45eda
Compare
Excellent work! Thank you. This is something I've been wanting for a while. I can finally go back to coding javascript now. ;-) |
thanks! I want |
Sounds great. :) I think your work on this feature was excellent, and I'm really appreciating the thorough tests you've added. So, I've added you as a collaborator to the project. Welcome to the team! |
Thanks! |
Probably not ready to be merged. Expect rough edge-cases :)