Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate: Handle targets being the same as subdomain #14

Open
MattIPv4 opened this issue Aug 7, 2022 · 1 comment
Open

Validate: Handle targets being the same as subdomain #14

MattIPv4 opened this issue Aug 7, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MattIPv4
Copy link
Member

MattIPv4 commented Aug 7, 2022

If an entry in cnames_active.js requests a target that is the same as the subdomain being requested (e.g. "test": "test.js.org"), we should have an error.
@MattIPv4
Copy link
Member Author

MattIPv4 commented Aug 7, 2022

Context: js-org/js.org#7499 (review)

@MattIPv4 MattIPv4 added enhancement New feature or request good first issue Good for newcomers labels Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MattIPv4