Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

concurrent-tasks.js.org #2573

Merged
merged 3 commits into from Dec 3, 2018
Merged

concurrent-tasks.js.org #2573

merged 3 commits into from Dec 3, 2018

Conversation

samrith-s
Copy link
Contributor

@samrith-s samrith-s changed the title Update cnames_active.js with concurrent-tasks concurrent-tasks.js.org Dec 3, 2018
MattIPv4
MattIPv4 approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit valid.

I trust that the site will have content and that is it ready to work with the js.org subdomain requested.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages labels Dec 3, 2018
@samrith-s
Copy link
Contributor Author

Yes, it will. It is the documentation for concurrent-tasks NPM package. Thank you! 😄

@indus indus added the provisional content This PR currently has limited content on the target and needs to be reviewed at a later time label Dec 3, 2018
@indus
Copy link
Member

indus commented Dec 3, 2018

https://concurrent-tasks.js.org
(I've marked this PR with the flag "provisional content" to check back on your page and make sure it fullfills the requirement of "reasonable content"; if that is not the case the subdomain may be revoked)

@indus indus merged commit 041d573 into js-org:master Dec 3, 2018
@samrith-s
Copy link
Contributor Author

@indus Thanks a lot, will drop in a comment here once I've updated, regardless.

@samrith-s
Copy link
Contributor Author

@indus I’ve updated the content. Please do check whenever. :)

@indus indus removed the provisional content This PR currently has limited content on the target and needs to be reviewed at a later time label Dec 5, 2018
@indus
Copy link
Member

indus commented Dec 5, 2018

@samrith-s thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samrith-s @indus @MattIPv4