Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manu.js.org #2610

Merged
merged 3 commits into from Dec 18, 2018
Merged

manu.js.org #2610

merged 3 commits into from Dec 18, 2018

Conversation

manu522
Copy link
Contributor

@manu522 manu522 commented Dec 16, 2018 •
edited

@manu522 manu522 changed the title Update cnames_active.js Add a new domain Dec 16, 2018
@manu522 manu522 changed the title Add a new domain manu.js.org Dec 16, 2018
MattIPv4
MattIPv4 requested changes Dec 16, 2018
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site. This file should contain a single line with the full js.org domain you are requesting, in this instance manu.js.org.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account awaiting CNAME This PR is waiting for the target to add a CNAME file labels Dec 16, 2018
@indus
Copy link
Member

indus commented Dec 17, 2018

I've already added your requested subdomain to JS.ORGs zonefile. But, as @MattIPv4 said, you have to (re-)add a file named CNAME to your branch with the single line manu.js.org to make it work.
I'll merge after we have "contact".

@manu522
Copy link
Contributor Author

manu522 commented Dec 17, 2018

Ok, I added it to the master branch

@MattIPv4 MattIPv4 removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Dec 17, 2018
@indus
Copy link
Member

indus commented Dec 18, 2018

Welcome https://manu.js.org

@indus indus merged commit 24e1b36 into js-org:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 requested changes

Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manu522 @indus @MattIPv4