Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umair.js.org #2951

Merged
merged 2 commits into from Apr 11, 2019
Merged

umair.js.org #2951

merged 2 commits into from Apr 11, 2019

Conversation

mumairofficial
Copy link
Contributor

I have added my profile link in the ascending order.
Kindly review my changes

I have added my profile link in the ascending order.
Kindly review my changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use a specific custom directory as the base of a GitHub pages site (to use a CNAME), it must be its own repository.

@mumairofficial
Copy link
Contributor Author

@MattIPv4 I have moved CNAME file along with index.html into root of directory

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/mumairofficial/mumairofficial.github.io

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account labels Apr 11, 2019
@MattIPv4 MattIPv4 changed the title Added cname for my github profile umair.js.irg Apr 11, 2019
@MattIPv4 MattIPv4 changed the title umair.js.irg umair.js.org Apr 11, 2019
@indus
Copy link
Member

indus commented Apr 11, 2019

Welcome https://umair.js.org

@indus indus merged commit 07e03bf into js-org:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants