Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umair.js.org #2951

Merged
merged 2 commits into from Apr 11, 2019

Conversation

Projects
None yet
3 participants
@mumairofficial
Copy link
Contributor

commented Apr 11, 2019

I have added my profile link in the ascending order.
Kindly review my changes

Added cname for my github profile
I have added my profile link in the ascending order.
Kindly review my changes
@MattIPv4
Copy link
Collaborator

left a comment

To use a specific custom directory as the base of a GitHub pages site (to use a CNAME), it must be its own repository.

@mumairofficial

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

@MattIPv4 I have moved CNAME file along with index.html into root of directory

@MattIPv4
Copy link
Collaborator

left a comment

Commit valid, CNAME present, site appears to have content *

* based off https://github.com/mumairofficial/mumairofficial.github.io

@MattIPv4 MattIPv4 added add user labels Apr 11, 2019

@MattIPv4 MattIPv4 changed the title Added cname for my github profile umair.js.irg Apr 11, 2019

@MattIPv4 MattIPv4 changed the title umair.js.irg umair.js.org Apr 11, 2019

@indus

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

@indus indus merged commit 07e03bf into js-org:master Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.