Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

denisvieira.js.org #3399

Merged
merged 1 commit into from Sep 28, 2019
Merged

denisvieira.js.org #3399

merged 1 commit into from Sep 28, 2019

Conversation

denisvieira05
Copy link
Contributor

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance denisvieira.js.org.

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Sep 27, 2019
@MattIPv4 MattIPv4 changed the title update username and personal website url denisvieira.js.org Sep 27, 2019
@denisvieira05
Copy link
Contributor Author

@MattIPv4 added CNAME , thank you man

@MattIPv4
Copy link
Member

@denisvieira05 It looks like GitHub hasn't picked it up, please check your repository settings and specifically the GitHub Pages section to check it is detecting the custom domain.

@denisvieira05
Copy link
Contributor Author

@MattIPv4 try now, i don't remember of the remove on old website repository, but now it's ok !

@MattIPv4
Copy link
Member

@denisvieira05 Hm, I don't see GitHub applying it still, does it show any error in the repository settings?

@denisvieira05
Copy link
Contributor Author

@MattIPv4 strange, sorry, but I try now to update the CNAME file and working correctly now .

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/denisvieira05/denisvieira05.github.io/tree/master

@denisvieira05
Copy link
Contributor Author

Thank you for you help !! @MattIPv4

@MattIPv4 MattIPv4 added change This PR/issue is regarding making a change to an existing subdomain user This PR/issue is regarding a target on a GitHub user account and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Sep 28, 2019
@indus
Copy link
Member

indus commented Sep 28, 2019

Welcome https://denisvieira.js.org
(you may want to update gamedevcontestal.js.org as well !?)

@indus indus merged commit 8f706cc into js-org:master Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change This PR/issue is regarding making a change to an existing subdomain user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants