Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undercut.js.org #3661

Merged
merged 1 commit into from Jan 13, 2020
Merged

undercut.js.org #3661

merged 1 commit into from Jan 13, 2020

Conversation

@the-spyke
Copy link
Contributor

the-spyke commented Jan 13, 2020

@the-spyke

This comment has been minimized.

Copy link
Contributor Author

the-spyke commented Jan 13, 2020

I must says that adding CNAME as a step #3 isn't very useful because at the time of PR on step #4 the site will have a broken DNS and no ability to check for No Content.

@MattIPv4

This comment has been minimized.

Copy link
Member

MattIPv4 commented Jan 13, 2020

We check content via the source if available. If not, we check the content once we've added the DNS record and will revert if there isn't valid content.

Copy link
Member

MattIPv4 left a comment

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance undercut.js.org.

@the-spyke

This comment has been minimized.

Copy link
Contributor Author

the-spyke commented Jan 13, 2020

@MattIPv4 Done: https://github.com/the-spyke/undercut/blob/gh-pages/CNAME

Copy link
Member

MattIPv4 left a comment

Commit valid, CNAME present, site appears to have content *

* based off https://github.com/the-spyke/undercut/tree/gh-pages

@MattIPv4 MattIPv4 added add project user and removed awaiting CNAME labels Jan 13, 2020
@indus

This comment has been minimized.

Copy link
Member

indus commented Jan 13, 2020

@indus indus merged commit 51f8597 into js-org:master Jan 13, 2020
@the-spyke

This comment has been minimized.

Copy link
Contributor Author

the-spyke commented Jan 13, 2020

Thank you very much!

@the-spyke the-spyke deleted the the-spyke:add-undercut branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.