Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undercut.js.org #3661

Merged
merged 1 commit into from Jan 13, 2020
Merged

undercut.js.org #3661

merged 1 commit into from Jan 13, 2020

Conversation

the-spyke
Copy link
Contributor

@the-spyke
Copy link
Contributor Author

I must says that adding CNAME as a step #3 isn't very useful because at the time of PR on step #4 the site will have a broken DNS and no ability to check for No Content.

@MattIPv4
Copy link
Member

We check content via the source if available. If not, we check the content once we've added the DNS record and will revert if there isn't valid content.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance undercut.js.org.

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Jan 13, 2020
@the-spyke
Copy link
Contributor Author

@MattIPv4 Done: https://github.com/the-spyke/undercut/blob/gh-pages/CNAME

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/the-spyke/undercut/tree/gh-pages

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Jan 13, 2020
@indus
Copy link
Member

indus commented Jan 13, 2020

Welcome https://undercut.js.org

@indus indus merged commit 51f8597 into js-org:master Jan 13, 2020
@the-spyke
Copy link
Contributor Author

Thank you very much!

@the-spyke the-spyke deleted the add-undercut branch January 13, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants