Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo.upptime.js.org #4894

Merged
merged 2 commits into from
Oct 28, 2020
Merged

demo.upptime.js.org #4894

merged 2 commits into from
Oct 28, 2020

Conversation

AnandChowdhary
Copy link
Contributor

Request:

I want a second-level subdomain. We already have https://upptime.js.org, but want to add a demo status page on https://demo.upptime.js.org. I know that Cloudflare natively supports this, so adding the CNAME record for demo.upptime.js.org. should work just as upptime.js.org. does.

The CNAME has already been added in the project: https://github.com/upptime/upptime/tree/gh-pages and the file is https://github.com/upptime/upptime/blob/gh-pages/CNAME.

If you're unable to accept this PR, I can use a different top-level subdomain, such as https://upptime-demo.js.org instead.

Related PRs:

Checks:

@indus
Copy link
Member

indus commented Oct 28, 2020

To make a second-level subdomain work we have to disable the CF-proxy. You will have to add teh comment //noCF at the end of your line (and care about SLL by your own). Other then that I don't see a problem.

@AnandChowdhary
Copy link
Contributor Author

Thanks, @indus! I've updated the PR with the // noCF comment. We can use GitHub Pages' SSL certificate and disable Cloudflare's proxy for this second-level subdomain. Thanks again for your help!

@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account labels Oct 28, 2020
@indus
Copy link
Member

indus commented Oct 28, 2020

Welcome http://demo.upptime.js.org

@indus indus merged commit abf0fc2 into js-org:master Oct 28, 2020
@AnandChowdhary AnandChowdhary deleted the patch-7 branch October 28, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants