Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fvuar.js.org #9108

Merged
merged 3 commits into from
Jun 25, 2024
Merged

fvuar.js.org #9108

merged 3 commits into from
Jun 25, 2024

Conversation

ahmetcanisik
Copy link
Contributor

cnames_active.js Outdated
@@ -1187,6 +1187,7 @@ var cnames_active = {
"funbook": "egoist.github.io/funbook",
"funcs": "funcs-package.github.io/docs",
"fusilli": "anthemaker.github.io/Fusilli.js",
"fvuar": "ahmetcanisik.github.io/fvuarjs/build",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot target a subdirectory of a website (the only exception being that we document the specific repository for a GitHub Pages user).

I suspect you want this to be http://ahmetcanisik.github.io/fvuarJS (note that repository names are case-sensitive).

As an aside, looking at https://github.com/ahmetcanisik/fvuarJS/tree/gh-pages, you'll want the files that are currently within build to be at the root of the branch so that GitHub Pages can serve them at fvuar.js.org, otherwise your site will be at fvuar.js.org/build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, thank you for these valuable warnings.

  • I moved my website files from the build folder to my home directory.
  • I went to cnames_active.js and edited it by adhering to the uppercase and lowercase letters and the github url path as you said.
  • The character encoding of my CNAME file was set to utf-16-ce, I changed it to utf-8 and added the fvuar.js.org line.

I hope that after these changes I made, my site will be accepted. Thank you for giving a time.

@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account and removed invalid labels Jun 25, 2024
@indus
Copy link
Member

indus commented Jun 25, 2024

Welcome https://fvuar.js.org

@indus indus merged commit 5ff43cc into js-org:master Jun 25, 2024
1 check passed
@ahmetcanisik
Copy link
Contributor Author

Dude, you are amazing 👍
The domain name looks legendary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants