generatePID + failOnError fixes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 7, 2014 23:14
…n case it's not a background process.
|
The generated PID is exactly what I was missing - thanks @nemo. Will be very happy to see that pull request merged soon. |
|
Yeah, just made natural sense @sha1n. Hopefully @js-seth-h will accept it ;) |
|
thank you for the contribution. |
js-seth-h
added a commit
that referenced
this pull request
Dec 10, 2014
generatePID + failOnError fixes
|
Anytime :) Nima Gardideh FRANK & OAK Mobile: +1 (647) 818-2503 On Tue, Dec 9, 2014 at 8:20 PM, Junsik Hwang notifications@github.com
|
|
@js-seth-h thanks for merging that pull request. Are you going to release a new version anytime soon? Thank you! |
|
ASAP. |
|
Cool! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Thanks for creating this! Helped me setup an auto spawn system for a node server I had.
Though, I hadn't setup a detached system on my node system so I thought it would be cool for grunt-service to be able to handle that case and auto-generate a pid file for it and take it to the background.
I've also made sure that failOnError actually works if it's set – it seems like it wasn't fully done before.