Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esprima-harmony@7001.1.0-dev-harmony-fb deprecated #343

Closed
davidpatters0n opened this issue Feb 4, 2015 · 5 comments
Closed

esprima-harmony@7001.1.0-dev-harmony-fb deprecated #343

davidpatters0n opened this issue Feb 4, 2015 · 5 comments

Comments

@davidpatters0n
Copy link

I have cloned the repo and did a sudo npm install inside my usr/lib/node_modules/js2ccoffee directory. When doing this I received

npm WARN deprecated esprima-harmony@7001.1.0-dev-harmony-fb: use esprima-fb instead

Should the dependencies need to be updated?
@rstacruz
Copy link
Member

rstacruz commented Feb 4, 2015

good catch... that's a recent deprecation on their part AFAIK.

@rstacruz
Copy link
Member

rstacruz commented Feb 4, 2015

btw, there's no need to sudo in npm install :) I recommend doing npm install && npm link if you want the js2coffee bin globally available from your dev instance.

@davidpatters0n
Copy link
Author

@rstacruz thanks. i'll close the issue.

@rstacruz
Copy link
Member

rstacruz commented Feb 5, 2015

nah lets keep it open until js2coffee migrates out of esprima-harmony. PR's welcome until I can attend to this around the weekend.

@rstacruz rstacruz reopened this Feb 5, 2015
rstacruz added a commit that referenced this issue Feb 6, 2015
@rstacruz
Use esprima-fb instead of esprima-harmony (#343)
06f2e05
@rstacruz
Copy link
Member

landed in v2.0.1, enjoy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rstacruz @davidpatters0n