Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
./build/msh
を実行後, を入力すると コアダンプになるバグの修正,およびそれに関連したいくつかの修正.変更点
line
とコマンド構造体cmd
をグローバル変数からローカル変数に変更し,引数で受け渡しするように変更した.こうすることで,メモリの確保と解放を変数宣言した関数で一括で行うことができ,メモリの解放漏れ等のリスクが低減した.
help
コマンドとcommand not found
の出力に色を付けたmsh.h
をinclude
していたが,コードの独立性を向上させるため,コード毎に必要なヘッダーをinclude
するようにしたstrnlen
からstrlen
を使用するようにしたRelated Issue
#3