-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHAT folder missing #3
Comments
I see now I can add an issue to my own fork if I enable it. However, since you ported it from JohnPool's original repo I'm wondering if anything was intentionally left off and if I should even bother trying to dig it up. Thoughts? Thanks in advance. |
Thank you for your reporting! I'm sorry to late because I was very busy for another some projects. Anyway, I'll figure out this issue. |
I researched about this issue on internet for a few hours. The result of researching is this: Fact
ConclusionI will remove "chat" predicate from predefined predicates, and release new version of CSharpProlog. |
P.S. I found "SAMPLES, TESTING & EXPERIMENTAL" section in predefined predicates.
I think that these predicates are not suitable for predefined predicates. Therefore, I'll remove all of the "SAMPLES, TESTING & EXPERIMENTAL" section from predefined predicates. |
I think that's a great idea. I'm going to submit a pull request for what I've been doing. If nothing else I'd like your comments on it. Nothing major (added a dotnetcore console app that works in linux, updated help text, etc). I THINK it will merge okay with the changes you are suggesting. I just don't want our forks to diverge too far. |
Thank you for your contributions! 👍 I'll merge your pull request after I understand what did you do. Unfortunately, I have a task that higher priority just now, so please give me one or few days to merge your pull request. |
No problem. My notes on the pull request itself will probably be better to help you understand than the commits. The reason is that in one commit I might have done something that worked, but then found a better way and committed that later. We can continue that conversation on the pull request itself. :) |
P.S. I'm started using GitHub project feature. |
I did it at 5f00b5e |
There is mention in CSProlog\bootstrap.cs of a CHAT folder that should be part of the repo. If you type chat it tries but can't find the file.
Is this something that was intentionally left out? Maybe couldn't be found? I think if the example code can't be found it's probably better removed from the comments also. It sure would be nice if we could find it and put it back in (assuming it wasn't left out on purpose), but the link mentioned in the comments is also dead. :(
Note: this is my first putting of an issue on someone else's repo so please forgive me if I've gone about it wrong. I'm open to correction.
The text was updated successfully, but these errors were encountered: