New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create aframe element instead of aframe-react Entity #1

Closed

jhsu wants to merge 1 commit into jsantell:master from jhsu:raw-aframe-element

jhsu commented Mar 17, 2017

instead of proxying props through <Entity /> we can just return an aframe element that accepts all the props the primitives accept.

I was thinking about creating react components for the primitives when I saw this library. 👍


          create aframe element instead of aframe-react Entity

fbd51dd

jhsu commented

View reviewed changes

src/index.js

    
              const renderEntityWithPrimitive = name => props =>

                <Entity primitive={name} {...omit(props, OMIT_PROPS)} />;

              const renderEntityWithPrimitive = primitive => props =>

                React.createElement(primitive, props);

Author

jhsu Mar 17, 2017

uses createElement with aframe's primitive

jhsu mentioned this pull request

Do not discard non-component properties when using primitives supermedium/aframe-react#50

Closed

jhsu closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment