Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up imports #8

Merged
merged 1 commit into from Feb 25, 2017
Merged

Conversation

perimosocordiae
Copy link
Contributor

  • move (almost) all imports to the top of the file
  • use the absolute_import syntax

This should help make any environment issues easier to debug, as missing imports will fail quickly.

 - move (almost) all imports to the top of the file
 - use the absolute_import syntax
@jsaponara jsaponara merged commit 52b3047 into jsaponara:master Feb 25, 2017
@jsaponara
Copy link
Owner

jsaponara commented Feb 25, 2017

Merged! The tests run fine but the linter sees errors. If you get a chance please let me know what you think the problem is. Thanks yet again CJ!

lint runtests: commands[0] | /home/john/dev/tax/opentaxforms/linting/fail-on-errs-only.sh
************* Module opentaxforms.Form
opentaxforms/Form.py:13: [E0401(import-error), ] Unable to import 'six.moves.urllib.request'
opentaxforms/Form.py:14: [E0401(import-error), ] Unable to import 'six.moves.urllib.error'
************* Module opentaxforms.config
opentaxforms/config.py:9: [E0401(import-error), ] Unable to import 'six.moves.urllib.request'
opentaxforms/config.py:10: [E0401(import-error), ] Unable to import 'six.moves.urllib.error'
************* Module opentaxforms.html
opentaxforms/html.py:81: [E0401(import-error), readImgSize] Unable to import 'PIL'
FAIL general linting: errors occurred

@perimosocordiae perimosocordiae deleted the clean-imports branch February 25, 2017 20:10
@perimosocordiae
Copy link
Contributor Author

Seems like the linting environment doesn't have the appropriate packages installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants