Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 2.0 support #4

Merged
merged 1 commit into from Jul 18, 2018
Merged

Django 2.0 support #4

merged 1 commit into from Jul 18, 2018

Conversation

smajda
Copy link
Contributor

@smajda smajda commented Jul 17, 2018

A simple change: adding the now-required on_delete to the ForeignKeys.

One test fails though:

FAIL: test_send_attachments (backend_tests.DBEmailBackendTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jon/.virtualenvs/bravo20/src/django-db-email-backend/db_email_backend/tests/backend_tests.py", line 56, in test_send_attachments
    self.assertEqual(attachment.mimetype, 'application/octet-stream')
AssertionError: 'text/markdown' != 'application/octet-stream'
- text/markdown
+ application/octet-stream

I'm not sure if the test is wrong (it's a markdown file, seems like 'text/markdown' would be correct...) or if it is supposed to be 'application/octet-stream' for some reason instead.

@jsatt jsatt merged commit 7a9b1df into jsatt:master Jul 18, 2018
@jsatt
Copy link
Owner

jsatt commented Jul 18, 2018

Thanks @smajda. Merged and released 0.4.

@smajda
Copy link
Contributor Author

smajda commented Jul 18, 2018

Thanks for the quick merge and release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants