Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive bin using keyboard shortcut #1520

Merged
merged 2 commits into from May 22, 2014
Merged

Archive bin using keyboard shortcut #1520

merged 2 commits into from May 22, 2014

Conversation

remy
Copy link
Member

@remy remy commented May 21, 2014

Fixes #756. Ref #1497, #1000.

remy added a commit that referenced this pull request May 22, 2014
Archive bin using keyboard shortcut
@remy remy merged commit 38bedba into master May 22, 2014
@remy remy deleted the feature/archive-keyb branch May 22, 2014 14:28
@dannyhope
Copy link
Member

Once archived I should be taken to my next bin. By next bin, I mean whatever appears next in the list of bins I see when I go to My Bins.

If this is implemented it will be easier to winnow my massive list of bins down to just those which I consider current/useful.

@remy
Copy link
Member Author

remy commented May 22, 2014

Hmm. Not sure I'd expect that or want that personally.

I get why you find it useful for grooming your current list of bins, but that one-off task aside, just like delete, once I archive, it doesn't mean I want to leave the bin, it just means I want to put it in the archive.

There's also the cognitive complexity of "what's the next bin?". Is it the next oldest? Next newest? What if there isn't a newer one? Do we go to the oldest? Does it do nothing? Does nothing seem like it's broken? When if I only have one bin?

Note: currently archive (as per the crappy homepage version) is only archiving snapshots, and not complete bins. This should be changed (but isn't easy - for the same reasons deleting the whole bin isn't easy).

From a technical perspective this is also pretty expensive to pull off: we need to run a fully query for all your bins, do relatively intensive sorting (which we already do, but isn't a reason to do more of it), and then serve up the next url - then handle what ever (convoluted?) logic that decides what's next.

Technical aside, I kind of feel like "archive + next" is a maintenance job that will only happen once in a while, whereas "archive this bin" I can see happening much more frequently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archive the bin I’m in
2 participants