Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkIfConvex for transformed polygon is failing #41

Closed
ZhekaS opened this issue Mar 27, 2014 · 1 comment
Closed

checkIfConvex for transformed polygon is failing #41

ZhekaS opened this issue Mar 27, 2014 · 1 comment

Comments

@ZhekaS
Copy link

ZhekaS commented Mar 27, 2014

The next piece of code will fail with "Not convex" exception:

function main() {
   var points = [ 
            [ 1,  1, 0],
            [-1,  1, 0],
            [-1, -1, 0],
            [ 1, -1, 0]
    ]
   var p = CSG.Polygon.createFromPoints(points);
   var m = CSG.Matrix4x4.rotation([0,0,0], [-0.56, 0.83, 0.00], 110);

   p.transform(m).checkIfConvex();

   return cube([0,0,0], 2)
}

It looks that it is failing whenever the polygon's normal vector is changing it's sign relatively to the original plane. But I am not sure.

@z3dev
Copy link
Member

z3dev commented Feb 17, 2017

This issue was moved to jscad/csg.js#18

@z3dev z3dev closed this as completed Feb 17, 2017
kaosat-dev added a commit that referenced this issue Apr 19, 2018
* adds all boilerplate needed to do cross platform releases : closes #32 and closes #40
* adds basic notification system to detect & inform of new releases : after some testing this is simpler and more efficient for now than auto updates : closes #24
kaosat-dev pushed a commit that referenced this issue Mar 12, 2019
…dable/simple xml handling(#41)

* Added ONML dependency
* added tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants