Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modeling): rework orthonormal formula #1214

Merged
merged 8 commits into from
Mar 25, 2023
Merged

feat(modeling): rework orthonormal formula #1214

merged 8 commits into from
Mar 25, 2023

Conversation

z3dev
Copy link
Member

@z3dev z3dev commented Mar 4, 2023

These changes rework the old orthonormal basis class into a common usable, fully tested class; OrthonormalFormula

This new class has been moved to math/utils/OrthonormalFormula.js, as well as creating a new test suite.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

@z3dev z3dev requested a review from platypii March 4, 2023 01:36
@z3dev
Copy link
Member Author

z3dev commented Mar 4, 2023

@platypii please take a look at the first take of the rework. this is now a real class with real methods.

next up, i want to rename this to OrthonormalFormula, as that's the real functionality, i.e. the formula allows sets of vectors (basis) to be converted to and from an orthonormal basis.

second, i will rework again to use a set for storing/returning 3D vertices, just like the little class in earcut.

third, i will optimize the creation of vectors, and calculations.

forth, i will add test cases.

any other requests?

packages/modeling/src/maths/OrthoNormalBasis.js Outdated Show resolved Hide resolved
packages/modeling/src/maths/OrthoNormalBasis.js Outdated Show resolved Hide resolved
@z3dev z3dev changed the title feat(modeling): rework orthonormal basis part 1 feat(modeling): rework orthonormal formula Mar 4, 2023
@z3dev z3dev requested a review from platypii March 5, 2023 04:23
@z3dev
Copy link
Member Author

z3dev commented Mar 5, 2023

@platypii this is ready now. please review.

i believe that OrthonormalFormula can also be used by earcut as well. Maybe a separate pull request?

@z3dev z3dev dismissed platypii’s stale review March 5, 2023 04:24

changes competes

Copy link
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall really nice change, just one small nit

packages/modeling/src/maths/utils/OrthonormalFormula.js Outdated Show resolved Hide resolved
@z3dev z3dev requested a review from platypii March 25, 2023 04:30
@z3dev
Copy link
Member Author

z3dev commented Mar 25, 2023

@platypii sorry for the delay. i finally got back to JSCAD. please review.

Copy link
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@z3dev z3dev merged commit 008a462 into V3 Mar 25, 2023
@z3dev z3dev deleted the rework-orthonormal branch June 27, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants