-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modeling): rework orthonormal formula #1214
Conversation
@platypii please take a look at the first take of the rework. this is now a real class with real methods. next up, i want to rename this to OrthonormalFormula, as that's the real functionality, i.e. the formula allows sets of vectors (basis) to be converted to and from an orthonormal basis. second, i will rework again to use a set for storing/returning 3D vertices, just like the little class in earcut. third, i will optimize the creation of vectors, and calculations. forth, i will add test cases. any other requests? |
@platypii this is ready now. please review. i believe that OrthonormalFormula can also be used by earcut as well. Maybe a separate pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall really nice change, just one small nit
@platypii sorry for the delay. i finally got back to JSCAD. please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
These changes rework the old orthonormal basis class into a common usable, fully tested class; OrthonormalFormula
This new class has been moved to math/utils/OrthonormalFormula.js, as well as creating a new test suite.
All Submissions: