Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 prerelease part 3 #1288

Merged
merged 7 commits into from
Sep 3, 2023
Merged

V3 prerelease part 3 #1288

merged 7 commits into from
Sep 3, 2023

Conversation

z3dev
Copy link
Member

@z3dev z3dev commented Sep 3, 2023

These changes are in preparation for publishing V3 alpha versions of the packages.

There are some code changes to modeling, as JSDOC barfed on those '@typedef' docs strings in mat4. I added proper TS definitions for those functions, and all is good again.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

Copy link
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fixes on Mat4, I wondered why those were necessary in the first place. Changes look good 👍

@z3dev z3dev merged commit 9fa56b7 into V3 Sep 3, 2023
4 checks passed
@z3dev z3dev deleted the v3-prerelease-part-3 branch September 24, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants