fix(modeling): geom2 mirroring transform #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jscad#1301 When a mirroring transform is applied to a geometry, we should reverse the point order so that orientation is preserved. This was already done for geom3/poly3 geometries, but was broken for geom2. This PR adds a check for negative 2D determinant to check if a transform is mirroring in 2D.
z3dev
approved these changes
Oct 4, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1301 (thanks @gilboonet)
When a mirroring transform is applied to a geometry, we should reverse the point order so that orientation is preserved.
This was already done for geom3/poly3 geometries here, but was not applied to geom2.
This PR uses the 2D determinant in
geom2.transformto check if a transform is a mirroring transform in 2D.Added to V3 branch since this is technically a breaking change. Although I would argue this is a fix of bad behavior.
All Submissions: