Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typo): fix then/than in rounded error messages #1327

Merged
merged 1 commit into from Mar 19, 2024
Merged

fix(typo): fix then/than in rounded error messages #1327

merged 1 commit into from Mar 19, 2024

Conversation

nmattia
Copy link
Contributor

@nmattia nmattia commented Mar 18, 2024

Got the error yesterday and spotted the typo

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

@nmattia
fix(typo): fix then/than in rounded error messages
8b70c10 
Got the error yesterday and spotted the typo
hrgdavor
hrgdavor approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@hrgdavor hrgdavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. If you are willing, could you check also on V3 branch ?

@nmattia nmattia mentioned this pull request Mar 18, 2024
Merged
3 tasks
@nmattia
Copy link
Contributor Author

nmattia commented Mar 18, 2024

@hrgdavor thanks for the quick review! I cherry picked it here: #1328

@z3dev z3dev merged commit f6d5286 into jscad:master Mar 19, 2024
2 checks passed
@nmattia nmattia deleted the nm-fix-typos branch March 19, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrgdavor hrgdavor hrgdavor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nmattia @hrgdavor @z3dev