Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using this toggles auto brightness on #4

Open
nhowardmit opened this issue Oct 7, 2021 · 17 comments
Open

Using this toggles auto brightness on #4

nhowardmit opened this issue Oct 7, 2021 · 17 comments
Labels
enhancement New feature or request

Comments

@nhowardmit
Copy link

Turn auto brightness off
Dim via this tweak
Undim via this tweak
Auto brightness gets toggled on
User gets the sads
@jschiefner
Copy link
Owner

fright not, here's how to change that:
toggle "modify auto-brightness" off in the AdvancedBrightnessSlider tweak preferences. Then toggle off Auto-Brightness in the accessibility settings one last time. The tweak should then stop adjusting the auto-brightness setting.

@nhowardmit
Copy link
Author

nhowardmit commented Oct 7, 2021 via email

@jschiefner jschiefner added the enhancement New feature or request label Oct 8, 2021
@jschiefner
Copy link
Owner

I don't disagree actually, i've read multiple comments where people were confused about this behaviour, i will look into it and change that in the next release. Thanks for your suggestions!

@jschiefner
Copy link
Owner

Hey, i made a new release (v1.1.0) to address this issue. I hope the Auto-Brightness toggling is less intrusive now, would you mind giving me your thoughts on the new release?

@nhowardmit
Copy link
Author

nhowardmit commented Jan 3, 2022 via email

@nhowardmit
Copy link
Author

Appears screenshot doesn’t make it onto here...

after upgrade no longer works

Opening settings generates an error:

AdvancedBrightnessSliderPreferences: stat() failed with error=45

“ReinstallEd” and got same error

removed, installed again, still same error

@jschiefner
Copy link
Owner

Normally you should be able to upload screenshots here. Where does this error appear exactly, in the preference pane of the tweak?

@nhowardmit
Copy link
Author

nhowardmit commented Jan 5, 2022 via email

@nhowardmit
Copy link
Author

Note:
Iphone SE(2) iOS 13.5

@jschiefner
Copy link
Owner

jschiefner commented Jan 11, 2022 •
edited
Loading

Hey, it seems like something changed in the Build System when i got a new MacBook. Could you to install those two .deb files manually and tell me if one or both work? I packed them up in a .zip file here:

Archive.zip

Installation instructions can be found here: https://idisqus.com/how-to-install-deb-files-ios-14-with-filza/

@nhowardmit
Copy link
Author

nhowardmit commented Jan 12, 2022 via email

@jschiefner
Copy link
Owner

Could you try the following versions as well? These are compiled with a M1 Macbook which i will use from now on to release so it is crucial that they work as well.

advancedbrightnessslider_1.1.0_m1_macbook_older_xcode_versions.zip

@jiyangzwb
Copy link

jiyangzwb commented Jan 18, 2022 •
edited
Loading

关闭了AdvancedBrightnessSlider ， 手机自动调节亮度不能正常运行，根据环境光源。

@jiyangzwb
Copy link

If turned off or uninstalled, the phone's automatic brightness adjustment function based on ambient light will not resume

@jschiefner
Copy link
Owner

@jiyangzwb can you specify what you tried to do, what you expected to happen and what happened instead?

@shMatrix
Copy link

shMatrix commented Oct 4, 2022

Hello @jschiefner
Thank you a lot for this really great tweak.
I would like to share with you my suggestions how your tweak can be improved more if you don't mind of cource.
THB, currently I don't understand the logic of using auto brightness while adjusting brightness via your tweak: sometimes auto brightness starts to work right away once I increased or decreased brightness, sometimes not (i'm not talking about reduced white point range now).
I would suggest to make it more clearly for example in that way:
Once brightness was adjusted via your tweak auto brightness mode should be completely disabled till user turns it on himself. And it could be cool to implement option like - "force auto brightness" directly in CC when it's needed, for example by touching the "sun icon" in brightness bar or in any other way. I understand that forcing auto brightness mode in reduced white point range could lead to unpredictable behavior, in that case I would suggest to implement logic\script like - once auto brightness was forced then tweak should disable "reduce white point" mode and force normal auto brightness mode.
What do you think?

@jschiefner
Copy link
Owner

Hi @shMatrix thank you so much for your thoughts, i greatly appreciate people taking interest in the tweak in this way 😊

I'm not too happy myself how this feature works but right now i don't have the time to work on this tweak. But I wanted to overhaul this feature for some time and add some kind of button like you suggested. I was gonna add it next to the "True Tone" button as a fourth one and maybe make that optional of some kind. When i have time again for this project i will for sure take your comment into consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shMatrix @jschiefner @nhowardmit @jiyangzwb