Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not setting bucket name causes confusing error #1140

Open
odigity opened this issue Jun 5, 2022 · 1 comment · Fixed by #1313
Open

Not setting bucket name causes confusing error #1140

odigity opened this issue Jun 5, 2022 · 1 comment · Fixed by #1313

Comments

@odigity
Copy link

odigity commented Jun 5, 2022

I'm learning django-storages by starting with zero configuration and adding what's needed one bit at a time to see how it alters behavior.

When I configure credentials but not a default bucket, then make a request to the server, it fails with a ValueError.

This stops happening as soon as I either set settings.AWS_STORAGE_BUCKET_NAME or set bucket_name in my storage subclass.

It may be worth adding an explicit check for required settings in order to provide a relevant error message informing the user of where they're falling short.

Traceback: https://gist.github.com/odigity/d73cf6338a5bb7908399cbe58d84572d

@sevdog
Copy link
Contributor

sevdog commented Oct 16, 2023

This should be reopened since #1322 reverted the fix for this.

@jschneier jschneier reopened this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants