enables passing security_token to constructor
#1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this line, `BaseStorage.__init__` raises an `ImproperlyConfigured` exception which prevents passing security_token as a parameter to `S3Boto3Storage.__init__`.
|
Thanks. I guess with this we can purge out line 259 and probably a bunch of stuff around there. Can you just start with removing that and I will send another cleanup PR. |
|
Never mind, it doesn't matter so I will take this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this line,
BaseStorage.__init__raises anImproperlyConfiguredexception which prevents passing security_token as a parameter toS3Boto3Storage.__init__.We use django-storages to manage a multi-tenant / multi-S3-bucket / multi-aws-account service. As a result, multiple
S3Boto3Storageclasses get instantiated with the proper information (access_key, secret_key and security_token).This line fixes our problem. I am not sure if there was a reason why
security_tokenis notlisted in default settings and/or if as a result it breaks some other use cases.