SFTP_BASE_URL and sftp.exists fix. #1363 #1364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi and thanks for the PR. If you want to separate out the I'm not sure I follow the other fixes, can you expand a bit more on what's going on? I looked at the ticket as well and have a glimpse but don't think I've managed to wrap my head all the way around it. |
|
I've added some more details to the ticket #1363 |
|
And here's the PR for just the SFTP_BASE_URL #1368 |
|
Took #1372 over this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue: #1363
Adds: SFTP_BASE_URL
Fixes: SFTPStorage.exists()
Plus a bit of logic so we only check for a parent directory's existence if there's a parent path provided.
I haven't managed to get tox to run, so if I could get some help with that, I can write a test or two for this.