Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for django >= '1.8' version and compatibility with django versions earlier #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juan-castano
Copy link

When someone using DocumentForm class on project appear a warning message with compatibility trouble. This warning has been fixed on this pull request.

@@ -14,7 +14,11 @@
try:
from django.utils.encoding import smart_unicode
except ImportError:
from django.forms.util import smart_unicode
if (django.get_version() < '1.8'):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably just use something like above with try ... except ImportError.

@RichLogan
Copy link

👍

Now that Django 1.9 has been officially released, this needs to happen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants