[ui] Support Markdown preview and live editor hot-swap #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
force-pushed
the
v8.17+lsp+goalview+doc
branch
from
5e88642
to
862692d
Compare
ejgallego
force-pushed
the
v8.17+lsp+goalview
branch
from
1a4c99b
to
e16b912
Compare
ejgallego
force-pushed
the
v8.17+lsp+goalview+doc
branch
from
b39901d
to
7c0475f
Compare
Still far from a benefit.
In order to support multiple editors we need the URI on the diagnostics, as we are updating the protocol we take advantage and make the request type closer to LSP too.
For now this changes only between CM5/6. Prosemirror support is more complex due to the offset hack.
This is better at many levels.
ejgallego
force-pushed
the
v8.17+lsp+goalview+doc
branch
from
7c0475f
to
3d71879
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a basic workflow for visualizing and editing markdown documents.
On top of #336
Demo at https://x80.org/rhino-down/