Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to "VR Grip" #20

Open
JScott opened this issue May 31, 2017 · 8 comments
Open

Rename to "VR Grip" #20

JScott opened this issue May 31, 2017 · 8 comments
Milestone

Comments

@JScott
Copy link
Owner

JScott commented May 31, 2017

I've tested this with Oculus Rift+Touch and it works. I should probably change the name to make that obvious. Marketing is important! Or so I hear.

@JScott JScott added this to the v3 milestone Jun 26, 2017
@JScott
Copy link
Owner Author

JScott commented Aug 30, 2017

It's probably worth waiting until I have native Oculus SDK support. Some platforms require the Oculus SDK for submission and I'm not sure that OpenVR makes the cut.

@m0o0scar
Copy link

Does this also work for Windows MR?

@JScott
Copy link
Owner Author

JScott commented Mar 12, 2018

Good question! I don't have a Windows MR device to test it but Vive Grip is built on SteamVR and I thiiiink Windows MR supports that? The Rift+Touch happened to work out of the box so I wouldn't be surprised.

@m0o0scar
Copy link

Yes. SteamVR unity plugin works for Windows MR too. But not out of the box, you need to install this Windows Mixed Reality for SteamVR though. I'll try ViveGrip on WindowsMR tonight, see if it works :)

@JScott
Copy link
Owner Author

JScott commented Mar 13, 2018

Oh wow, thanks! I appreciate the check whenever you have a chance to get around to it.

To get a bit more detailed, as long as it responds to SteamVR_Controller.Device's GetPressDown, GetPressUp, and GetPress for these inputs then it should be fine. I don't know how the WinMR controller is laid out though so maybe there'll be some unexpected results.

@m0o0scar
Copy link

m0o0scar commented Mar 14, 2018

FYI

Windows MR Controller

  1. The buttons, layout and function of the buttons are basically the same as VIVE controller.
  2. With one exception that there's a thumbstick besides the touchpad. Usually the thumbstick is used to teleport around while the touchpad is for scrolling UI elements. The thumbstick also has a click event.
  3. Also the WMR controller is lighter and smaller than the VIVE's.

@m0o0scar
Copy link

Just tested ViveGrip with Windows Mixed Reality (Samsung Odyssey HMD), it works! Objects in the example scene could be picked up by holding the grip button and used by clicking the trigger button. You're now officially VRGrip :D

@JScott
Copy link
Owner Author

JScott commented Mar 20, 2018

Fantastic! Thank you so much for letting me know :D

I feel like it's more SteamVRGrip at this point because it doesn't have native WinMR or Rift support which causes significant barriers, like getting your app published on Oculus Home. Still, it's very exciting to hear that it functions across the board, opening up the opportunities for creators.

I guess at the very least I should update the readme to list WinMR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants