Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor ParallaxProvider to function component #230

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

jscottsmith
Copy link
Owner

No description provided.

Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-scroll-parallax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 6:47am

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9ebdd5) 88.88% compared to head (9ccae5c) 89.13%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   88.88%   89.13%   +0.24%     
==========================================
  Files          23       23              
  Lines         234      230       -4     
  Branches       49       44       -5     
==========================================
- Hits          208      205       -3     
+ Misses         25       24       -1     
  Partials        1        1              
Files Coverage Δ
...c/components/ParallaxProvider/ParallaxProvider.tsx 100.00% <100.00%> (+4.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 1, 2023

size-limit report 📦

Path Size
dist/react-scroll-parallax.cjs.production.min.js 5.85 KB (-4.97% 🔽)
dist/react-scroll-parallax.esm.js 975 B (-83.72% 🔽)

@raRaRa
Copy link

raRaRa commented Nov 1, 2023

Hopefully this solves all the issues with Nextjs 14 🙏

@jscottsmith jscottsmith merged commit 290dab0 into master Nov 2, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants