Skip to content
This repository has been archived by the owner on Dec 29, 2020. It is now read-only.

Tighten up dependancy versions #42

Closed
jansepar opened this issue May 14, 2014 · 3 comments
Closed

Tighten up dependancy versions #42

jansepar opened this issue May 14, 2014 · 3 comments
Assignees

Comments

@jansepar
Copy link

Hi!

We're currently using grunt-jscs-checker in one of our projects, and recently, there was an update to node-jscs in 1.4.4 that caused everything to break (jscs-dev/node-jscs#376).

Since your version dependancy was set to ~1.4.3 (which really means 1.4.X), it was causing us to download the broken 1.4.4. I would suggest being explicit about which version to match rather then using ~.

Let me know if you think this is a good change :)

@markelog
Copy link
Member

Just don't panic, it happens, new version of jscs is published

@jansepar
Copy link
Author

It's not about panicking - this is obviously a special case where jscs was completely broken. But what if there was a less obvious bug that was introduced in jscs 1.4.5? I don't see why you wouldn't just want to lock the version explicitly to avoid issues arising in the future.

@gustavohenke gustavohenke self-assigned this May 14, 2014
@gustavohenke
Copy link
Member

Hey @jansepar, a new version 0.4.4 has been published with jscs@1.4.5.
I hope it helps someone!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants