1.4.4 broke requireLeftStickOperator for comma and jquery preset

[nschonni]

See https://travis-ci.org/wet-boew/wet-boew/builds/25194225
Using the jquery preset, errors are no raised for commas that stick to the left operator even though that is required in the rule https://github.com/mdevils/node-jscs/blob/master/presets/jquery.json#L19

[mikesherov]

Yup... Massive break.

[mikesherov]

Just discovering it in my CI now. @markelog urgent.

[mikesherov]

Also, if you specify = and not , it still validates ,!

[markelog]

afk right now, but will get back to my desk in 10 minutes

[mikesherov]

if (operators[','] || operators['=']) {
            file.iterateTokensByType('Punctuator', function(token, i, tokens) {
                var operator = token.value;
                if (operator !== ',' && operator !== '=') {

makes it validate , for = and vice versa. Just a drop too clever. We'll need a 1.4.5 tonight.

[MikeKlemarewski]

Is this change going to be released soon? It's breaking https://github.com/gustavohenke/grunt-jscs-checker because of they specify ~1.4.3 for node-jscs.

[markelog]

@MikeKlemarewski very soon

[markelog]

New version is published

[nschonni]

Thanks @markelog!

[MikeKlemarewski]

@markelog Thanks for the swift action!

[gustavohenke]

Hey @MikeKlemarewski, a new version of grunt-jscs-checker has just been published skipping the buggy 1.4.4.

[MikeKlemarewski]

@gustavohenke Thanks! Might be good to be more strict on dependencies to avoid these kind of breakages.

[sylvain-hamel]

Thanks for the fast turnaroud

[NickHeiner]

👍 thanks for the quick fix!