This repository has been archived by the owner on Dec 29, 2020. It is now read-only.
Create new checker for every jscs target run #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Say, for example, you have this in
Gruntfile
You don't have errors in
main.js
, but you do have one insecondary.js
.Then, you run
grunt jscs
command without specifying the target, as a result, both targets will be run.In stdout you get three absolutely identical errors found in
secondary.js
, instead of one.This would happen because
lines will be executed twice, whereas
Checker
constructor (which is initialized from out of context ofjscs
task) saves the rules in the returned object, so they will be augment every time.This commit resolves the problem.