-
Notifications
You must be signed in to change notification settings - Fork 46
Conversation
Anytime you do an npm install or update, NPM will reformat to 2 spaces |
What? |
@nschonni no, it'll not, unless you pass |
|
||
"node": true | ||
"undef": true, | ||
"unused": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of sorting this kind of stuff, creates additional complicity to something very simple.
Indentation is also debatable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always follow alphabetical order because it simply is easier to spot the option I'm looking for without looking randomly or using search. As for indentation, I don't really care either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ctrl+f/cmd+f? If someone would want to add something, he would have to sort this list to figure it out, which sounds...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really. I simply do Alt+O
in the same editor I use and the values are sorted by name.
It's better to be consistent i think, if we use four spaces everywhere else it's weird to do it differently in one other file. |
I disagree. package.json should follow what I mostly care about the rest of the changes. |
Great, other changes looks good to me |
@markelog sorry I was a little unclear in the previous comment, but @gustavohenke clarified that anytime NPM modifies the package.json, it will change the indenting of the file to 2 spaces. |
So do I rebase to revert the package.json and jshintrc indentation changes? I'm still in favor of those changes for the reasons I explained above, but the final decision is for the project maintainers to make. |
I would prefered, yes, but final decision on @gustavohenke |
About Squash and when you're done and we're good to merge. |
This check should be moved to JSCS later.
Sort properties by name and reindent it for better readability.
The preferred way is to install it globally.
Branch rebased. I kept the jshintrc changes. Squash doesn't make sense here; each patch is for a different thing. |
Thanks! BTW, maybe you should add a License for the project? |
Why not! |
@gustavohenke: feel free to add it, I don't know which license you prefer :) |
BTW, any plans to make a new npm package after you add the license? The changes aren't big but can be useful. |
About the license, I'm waiting for remy/mit-license#452. Too lazy to customize my own :P |
I added the license in #34 |
Maybe wait a couple more days; there will be a new jscs release soon-ish hopefully. |
Let me know if you want me to make any changes and I'll rebase the branch.