checkReturnTypes: skip checking 'this.something'

Fixes #115
jscs-dev · Jul 1, 2015 · 41b5b7b · 41b5b7b
1 parent 80c3ea7
commit 41b5b7b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/jsdoc.js b/lib/jsdoc.js
@@ -519,12 +519,16 @@ function jsDocMatchType (variants, argument) {
             result = result || (type === 'array');
 
         } else if (argument.type === 'NewExpression' && type === 'object') {
-            result = result || true;
+            result = true;
 
         } else if (argument.type === 'NewExpression') {
             var c = argument.callee;
             var exam = c.name;
             if (!exam && c.type === 'MemberExpression') {
+                if (c.object.type === 'ThisExpression') {
+                    result = true;
+                    break;
+                }
                 var cur = c;
                 exam = [];
                 while (cur.object) {

diff --git a/test/lib/rules/validate-jsdoc/check-return-types.js b/test/lib/rules/validate-jsdoc/check-return-types.js
@@ -291,6 +291,16 @@ describe('lib/rules/validate-jsdoc/check-return-types', function () {
                         };
                     };
                 }
+            }, {
+                it: 'should not report on `@returns {Class}` for `new this.*`. issue #115',
+                code: function () {
+                    /**
+                     * @returns {Element}
+                     */
+                    function foo() {
+                        return new this.something();
+                    }
+                }
             }
             /* jshint ignore:end */
         ]);