Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added @listens tag to jsdoc3.json #192

Merged
merged 1 commit into from Mar 16, 2016
Merged

Added @listens tag to jsdoc3.json #192

merged 1 commit into from Mar 16, 2016

Conversation

ianmcburnie
Copy link
Contributor

Fixes issue #191

@apsavin
Copy link

apsavin commented Mar 16, 2016

@zxqfox can we merge this?

@qfox
Copy link
Member

qfox commented Mar 16, 2016

Oh, sorry.

qfox added a commit that referenced this pull request Mar 16, 2016
@qfox qfox merged commit 5973c74 into jscs-dev:master Mar 16, 2016
@apsavin
Copy link

apsavin commented Mar 16, 2016

Thank you very much! Now you can close #191 and push a new version to npm)

@apsavin
Copy link

apsavin commented Mar 22, 2016

@zxqfox please-please-please, publish a version. Is there any reason not to do it?

2016-03-22 13 35 45

qfox pushed a commit that referenced this pull request Mar 22, 2016
@qfox
Copy link
Member

qfox commented Mar 22, 2016

@apsavin Sorry, v1.3.2 published.

@apsavin
Copy link

apsavin commented Mar 22, 2016

Thank you so very much!;)

@qfox
Copy link
Member

qfox commented Mar 22, 2016

Btw, you don't need to wait for new tags. You can easily add them to your config via extra field:

{
  "checkAnnotations": {
    "preset": "jsdoc3",
    "extra": {
      "listens": true
    }
  }
}

@apsavin
Copy link

apsavin commented Mar 22, 2016

Sure. Thanks for the tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants