requireEnhancedObjectLiterals: Don't error for computed properties

Fixes #2013 Closes gh-2058
jscs-dev · Jan 19, 2016 · 168009d · 168009d
1 parent cc8a9e0
commit 168009d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/rules/require-enhanced-object-literals.js b/lib/rules/require-enhanced-object-literals.js
@@ -54,9 +54,10 @@ module.exports.prototype = {
             var propertyName = node.key.name || node.key.value;
             var valueName = node.value.name;
             var shorthand = node.shorthand;
+            var computed = node.computed;
 
             // check for non-shorthand properties
-            if (propertyName && propertyName === valueName && !shorthand) {
+            if (propertyName && propertyName === valueName && !(shorthand || computed)) {
                 errors.add(
                   'Property assignment should use enhanced object literal function.\n' +
                   ' `{ propName: propName }` is not allowed.',

diff --git a/test/specs/rules/require-enhanced-object-literals.js b/test/specs/rules/require-enhanced-object-literals.js
@@ -32,6 +32,13 @@ describe('rules/require-enhanced-object-literals', function() {
 
             expect(checker.checkString(code)).to.have.no.errors();
         });
+
+        it('allows computed keys ', function() {
+            var checker = buildChecker({ requireEnhancedObjectLiterals: true });
+            var code = 'const COMMENTS = { [SINGLE_COMMENT]: SINGLE_COMMENT }';
+
+            expect(checker.checkString(code)).to.have.no.errors();
+        });
     });
 
     describe('when { requireEnhancedObjectLiterals: false }', function() {