Bug with indentation for multiline comments

[royerboat]

Getting a strange indentation error inside of a multi-line comment.

The following code that triggers the warning:

/*
# this is a line
# this is another line
*/
var hello = "World";

Actual warning result:

validateIndentation: Multiline comments should not have tokens on its ending line at jscs-bug.js :
     1 |/*
     2 |# this is a line
----------^
     3 |# this is another line
     4 |*/


1 code style error found.

The validate config I'm using:
"validateIndentation": 4

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[mikesherov]

@royerboat this will be fixed in the next release. Thanks for contributing!

[royerboat]

Glad to hear it! Thanks for responding so quickly!

[mikesherov]

This no longer triggers an error once 1.12 goes out, but we're still doing unsafe manipulations to the code when a # appears inside a multiline token like:

/*
#
*/

or

var a = "\
#\
";

cc @markelog or @zxqfox or @mdevils

[Reinmar]

Another test case:

   345 |  );
Multiline comments should not have tokens on its ending line at core/loader.js :
   227 |/*
   228 |foo
   229 |*/ // %REMOVE_LINE%
----------^
   230 |

Passes on master, throws on v1.11.3.

[markelog]

At this point only major and CST related bugs will be fixed.